Added UMD wrapper around directive so it can be used with webpack or other module loaders as well as standalone script#2
Open
davestaab wants to merge 6 commits intonmutalik:masterfrom
Open
Conversation
Author
|
Any chance this can be merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've wrapped the module in a UMD wrapper.
I used this one: https://github.com/umdjs/umd/blob/master/templates/returnExports.js
More info can be found here: https://github.com/umdjs/umd
This shouldn't change it's behavior when using it as a standalone script but it will also allow it to be used with webpack or other module loader systems.
Let me know what you think.