Skip to content

Minor documentation clarifications #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleg-alexandrov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor documentation clarifications #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ include_directories(SYSTEM
${CMAKE_SOURCE_DIR}/elibs/rayint/libs
${CMAKE_SOURCE_DIR}/elibs/mve/libs
${CMAKE_SOURCE_DIR}/elibs/eigen
${CMAKE_SOURCE_DIR}/elibs/mapmap/
${CMAKE_SOURCE_DIR}/elibs/mapmap
${CMAKE_SOURCE_DIR}/elibs/mapmap/mapmap
${CMAKE_SOURCE_DIR}/elibs/mapmap/ext/dset
)
Expand Down
2 changes: 1 addition & 1 deletion apps/texrecon/arguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Arguments parse_args(int argc, char **argv) {
args.add_option('L',"labeling_file", true,
"Skip view selection and use the labeling provided in the given file");
args.add_option('d',"data_term", true,
"Data term: {" +
"Data term (face area, or magnitude of image gradient times face area): {" +
choices<tex::DataTerm>() + "} [" +
choice_string<tex::DataTerm>(tex::DATA_TERM_GMI) + "]");
args.add_option('s',"smoothness_term", true,
Expand Down
2 changes: 1 addition & 1 deletion libs/tex/texture_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class TextureView {
*/
bool valid_pixel(math::Vec2f pixel) const;

/** TODO */
/** Returns if all three given points (that are usually vertices of a face) project in the view at valid pixels. */
bool inside(math::Vec3f const & v1, math::Vec3f const & v2, math::Vec3f const & v3) const;

/** Returns the RGB pixel values [0, 1] for the give pixel location. */
Expand Down