Skip to content

Raise Http404 rather than return HttpResponseNotFound #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SociologicalReview wants to merge 6 commits into
base: release
Choose a base branch
from
Open

Raise Http404 rather than return HttpResponseNotFound #62

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
560e872
change return HttpResponseNotFound to raise Http404
SociologicalReview Aug 21, 2025
2d5307c
view code updated
SociologicalReview Aug 21, 2025
f3cb998
more error handling in view
SociologicalReview Aug 21, 2025
c110640
use specific() rather than specific_class
SociologicalReview Aug 22, 2025
84b1450
use specific rather than specific_class
SociologicalReview Aug 22, 2025
770855d
Additional information provided with error messages
SociologicalReview Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions wagtail_qrcode/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
from django.http import HttpResponseNotFound, HttpResponseRedirect
from django.http import Http404, HttpResponseRedirect
from wagtail.models import Page


def qr_code_page_view(request):
"""QR code redirect view."""
page_id = int(request.GET.get("id"))
try:
page_id = int(request.GET.get("id"))
except ValueError:
raise Http404("Page ID not valid, incorrect value")
except TypeError:
raise Http404("Page ID not present, incorrect type")

try:
specific_cls = Page.objects.get(id=page_id).specific_class
page = specific_cls.objects.get(id=page_id)
page = Page.objects.get(id=page_id).specific
except Page.DoesNotExist:
return HttpResponseNotFound("Page not found")
raise Http404

if hasattr(page, "qr_code_usage"):
page.qr_code_usage += 1
page.save()
return HttpResponseRedirect(page.url)

return HttpResponseNotFound("Page not found")
return HttpResponseRedirect(page.url)