feat(info/userNonFundingLedgerUpdates): add new update types for UserNonFundingLedgerUpdatesResponse #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NonFundingLedgerUpdatesResponse
There was a problem hiding this comment.
Pull request overview
Adds support for additional delta.type variants returned by the userNonFundingLedgerUpdates Info endpoint, and expands the corresponding schema-coverage test samples.
Changes:
- Extended
UserNonFundingLedgerUpdatesResponse.deltavariant schema with new update types (borrowLend,spotGenesis,activateDexAbstraction). - Updated the Info API test to query additional users to improve schema branch coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/api/info/userNonFundingLedgerUpdates.test.ts | Adds additional API samples to exercise newly added delta variants. |
| src/api/info/_methods/userNonFundingLedgerUpdates.ts | Adds new delta.type variant definitions to the response schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nktkas
deleted the
107-missing-activatedexabstraction-type-in-usernonfundingledgerupdatesresponse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.