Fix RoomLoader ENEMY_SCENES mapping and add missing archetypes#267
Conversation
…ypes - Added "mage" and "boss" archetypes to ENEMY_SCENES in room_loader.gd. - Switched ENEMY_SCENES to use preload() for better efficiency and to follow standard practice. - Created enemy_mage.tscn and enemy_boss.tscn in scenes/enemies/. - Created enemy_mage.gd and enemy_boss.gd in scripts/entities/enemies/. - Updated test_enemy_variety.gd with new archetype tests. - Verified fix with a new spawn test. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Reformatted `tests/test_new_enemies_spawn.gd` to satisfy CI linting requirements. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
niyazmft
deleted the
fix/roomloader-enemy-scenes-mapping-4337679490291077411
branch
1 participant
This PR completes the mapping of enemy archetypes in
RoomLoader.gdby adding "mage" and "boss". It also switches the mapping to usepreload()for all archetypes. Corresponding scene and script files for the new archetypes have been created, and tests have been updated and verified.Fixes #246
PR created automatically by Jules for task 4337679490291077411 started by @niyazmft