Add missing ability config keys to ConfigLoader DEFAULTS#266
Conversation
Added "ability_min" and "ability_max" to the DEFAULTS dictionary in scripts/autoload/config_loader.gd. This ensures that the CombatFormula.action_cost() lookups have valid fallback values and comply with the ConfigLoader's requirement that all valid keys be present in the DEFAULTS dictionary. These values (3 and 5) match the constants defined in scripts/core/constants.gd and the current config/game_config.json. Fixes issue #245. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
niyazmft
deleted the
fix/combat-formula-ability-config-defaults-10096949999039197930
branch
1 participant
Added missing
ability_minandability_maxkeys toConfigLoader.DEFAULTSto ensure correct fallback behavior inCombatFormula.action_cost(). Verified the fix with both unit tests and a reproduction script that bypasses JSON loading to confirmDEFAULTSlookup works as intended. Removed all temporary testing artifacts before submission.Fixes #248
PR created automatically by Jules for task 10096949999039197930 started by @niyazmft