Migrate legacy JSON parsing to JSON.parse_string()#265
Conversation
…ON.parse_string() Migrated JSON parsing logic in 8 files from the legacy Godot 3.x pattern (JSON.new().parse()) to the modern Godot 4.x idiomatic pattern (JSON.parse_string()). Files migrated: - scripts/combat/room_loader.gd - scripts/core/encounter_system.gd - scripts/core/loot_table.gd - scripts/core/room_generator.gd - scripts/autoload/settings_manager.gd - scripts/autoload/grid_system.gd - scripts/autoload/save_manager.gd - scripts/entities/apparition_renderer.gd Verified via headless Godot syntax check and GdUnit4 test suite (171/171 passed). Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
niyazmft
deleted the
chore/migrate-legacy-json-parsing-7648556505605595903
branch
1 participant
Migrated JSON parsing in 8 scripts to use Godot 4.x
JSON.parse_string(), ensuring consistency with modern project standards and improving code readability. Each migration includes robust type-checking of the parsed data.Fixes #247
PR created automatically by Jules for task 7648556505605595903 started by @niyazmft