chore(BaseEnemy): apply_damage passes null as attacker, losing log context#262
Conversation
…ntext - Updated scripts/entities/base_enemy.gd:apply_damage to accept an optional attacker parameter. - Updated scripts/entities/keeper.gd:apply_damage to accept an optional attacker parameter. - Passed the attacker parameter to EntityLifecycle.apply_damage instead of hardcoded null. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…xt-17485899740873760573
niyazmft
deleted the
chore/base-enemy-apply-damage-attacker-context-17485899740873760573
branch
1 participant
Modified the apply_damage signature in BaseEnemy and Keeper to accept an optional attacker: Entity parameter and pass it to EntityLifecycle. This ensures that damage events (e.g., retribution, environmental) preserve the attacker identity for logging and burden tracking.
Fixes #249
PR created automatically by Jules for task 17485899740873760573 started by @niyazmft