Skip to content

termios: Add definition for IUCLC#2702

Merged
SteveLauC merged 1 commit into
nix-rust:masterfrom
3v1n0:add-IUCLC
Jan 22, 2026
Merged

termios: Add definition for IUCLC#2702
SteveLauC merged 1 commit into
nix-rust:masterfrom
3v1n0:add-IUCLC

Conversation

@3v1n0
Copy link
Copy Markdown
Contributor

@3v1n0 3v1n0 commented Nov 21, 2025

What does this PR do

Adds IUCLC definition

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

Needs: rust-lang/libc#4846
Related: uutils/coreutils#9432

@3v1n0 3v1n0 marked this pull request as draft November 21, 2025 23:45
@3v1n0
Copy link
Copy Markdown
Contributor Author

3v1n0 commented Nov 21, 2025

Marking a draft until newer libc is released

@3v1n0
Copy link
Copy Markdown
Contributor Author

3v1n0 commented Dec 3, 2025

As update, this landed in libc 0.2.178, but... That also broke nix tests, and so we need to wait for the new one that will contain rust-lang/libc@d5b0f29 🤯

@3v1n0
Copy link
Copy Markdown
Contributor Author

3v1n0 commented Jan 13, 2026

This now depends on #2724

@3v1n0 3v1n0 force-pushed the add-IUCLC branch 2 times, most recently from 95adb29 to 0d030ea Compare January 22, 2026 10:48
@3v1n0 3v1n0 marked this pull request as ready for review January 22, 2026 10:49
@3v1n0
Copy link
Copy Markdown
Contributor Author

3v1n0 commented Jan 22, 2026

@SteveLauC thanks for the release, also this and #2703 would be nice to be released so we can unblock coreutils :)

@SteveLauC
Copy link
Copy Markdown
Member

also this and #2703 would be nice to be released so we can unblock coreutils :)

Yeah, absolutely!

Copy link
Copy Markdown
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry for this new feature following the guide here?

@3v1n0
Copy link
Copy Markdown
Contributor Author

3v1n0 commented Jan 22, 2026

Sure, let me add that

@SteveLauC SteveLauC enabled auto-merge January 22, 2026 11:00
@SteveLauC SteveLauC added this pull request to the merge queue Jan 22, 2026
Merged via the queue into nix-rust:master with commit a69b2c1 Jan 22, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants