Skip to content

Update tests and version regex#195

Open
jinluchang wants to merge 12 commits into
nix-community:mainfrom
jinluchang:main
Open

Update tests and version regex#195
jinluchang wants to merge 12 commits into
nix-community:mainfrom
jinluchang:main

Conversation

@jinluchang

Copy link
Copy Markdown

Mainly change the regex ".Module ([0-9.]+) ." to ".NVIDIA UNIX.Kernel Module. ([0-9]+\.[0-9]+) ." in file nixGL.nix to accommodate new version string.

SFrijters added a commit to SFrijters/nixGL that referenced this pull request May 24, 2025
@dyfrgi

dyfrgi commented Jul 5, 2025

Copy link
Copy Markdown

Seems like a step in the right direction, once the cachix change is removed. I wonder if we could somehow automate keeping the list of NVidia driver versions up to date?

Comment thread .github/workflows/test.yml Outdated
name: guibou
authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
- uses: actions/checkout@v4
- uses: cachix/install-nix-action@v30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is superseded by #201.

@samestep

Copy link
Copy Markdown

Thank you @jinluchang! I kept getting error: cannot coerce null to a string: null because my /proc/driver/nvidia/version looks like this:

NVRM version: NVIDIA UNIX Open Kernel Module for x86_64  575.57.08  Release Build  (dvs-builder@U22-I3-H04-01-5)  Sat May 24 07:03:13 UTC 2025
GCC version:  gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04)

This PR fixed the issue. I hope it gets merged soon.

@dyfrgi

dyfrgi commented Jul 12, 2025

Copy link
Copy Markdown

Thank you @jinluchang! I kept getting error: cannot coerce null to a string: null because my /proc/driver/nvidia/version looks like this:

NVRM version: NVIDIA UNIX Open Kernel Module for x86_64  575.57.08  Release Build  (dvs-builder@U22-I3-H04-01-5)  Sat May 24 07:03:13 UTC 2025
GCC version:  gcc version 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04)

This PR fixed the issue. I hope it gets merged soon.

The conflicts need resolving first. Since it was left untouched for a while I don't know if @jinluchang is interested in continuing with it. If not, you could pick it up, @samestep.

@samestep

Copy link
Copy Markdown

Oh sure @dyfrgi, I can take a look. I'm guessing I can't edit this PR, should I just open a separate one?

@jinluchang

Copy link
Copy Markdown
Author

@dyfrgi @samestep Sorry for the delay. I have merged the latest change from the main branch and fixed the conflict.

@samestep

Copy link
Copy Markdown

@jinluchang looks like the build is failing?

@jinluchang

Copy link
Copy Markdown
Author

@samestep The failure is due the recent commit "fix: set GBM_BACKENDS_PATH" 3865170

which add "export GBM_BACKENDS_PATH=${lib.makeSearchPathOutput "lib" "lib/gbm" mesa-drivers}" to nixGL.

This change caused the test to fail.

However, the test would work with more recent nixpkgs. Perhaps we should advance the rev in "nixpkgs.nix"?

@samestep

Copy link
Copy Markdown

@dyfrgi is this ready to be merged now?

@samestep

Copy link
Copy Markdown

@dyfrgi are there any blockers for merging this?

@dyfrgi dyfrgi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants