Fixing validation issues and tag injection#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces stricter validation for HTML tag names, CSS property names, and theme token names/values to prevent injection vulnerabilities and malformed output in NitroUI. The changes add regular expression-based validation and raise clear errors for invalid input throughout the element, style, stylesheet, and theme modules.
Security and Validation Improvements
tagsetter ofElement, ensuring they start with a letter and only contain letters, digits, and hyphens.CSSStyleand the stylesheet renderer, blocking unsafe identifiers and injection vectors. [1] [2] [3] [4] [5] [6]Theme.get_css_variables()to ensure only safe identifiers and values are used for CSS custom properties. [1] [2]Other Changes
1.0.10to1.0.11.