Fixed numerous bugs#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the
nitro-datastorepackage, focusing on enhanced error handling, improved efficiency, and minor documentation and versioning updates. The most significant change is the addition of astrictmode to thefrom_directorymethod, allowing users to control how invalid JSON files are handled during directory loading.Error Handling & API Improvements:
strictparameter to theNitroDataStore.from_directorymethod, enabling users to choose whether invalid JSON files should raise exceptions or be skipped silently. The method's docstring and exception documentation were updated accordingly. [1] [2] [3] [4] [5]Performance & Code Quality:
diffmethod inNitroDataStoreby creating a singleNitroDataStoreinstance for theotherargument, reducing redundant instantiations and improving efficiency.QueryBuilder.first()where thelimitwas not reset after execution, ensuring correct behavior for subsequent queries.Versioning:
1.0.2to1.0.3inpyproject.toml.