[FIX] force_fmapless on top of self-correcting pepolar bold#465
[FIX] force_fmapless on top of self-correcting pepolar bold#465bpinsard wants to merge 6 commits into
Conversation
|
Also, it seems there was no test for |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 30 30
Lines 2826 2826
Branches 367 367
=======================================
Hits 2367 2367
Misses 387 387
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b48366a to
dc6d2f7
Compare
|
Not sure how that will behave with multi-subject cases, seee #455 . |
effigies
left a comment
There was a problem hiding this comment.
I'm not sure how I feel about this, now that I've implemented application of pre-computed fieldmaps. In practice, the way to discover the relevant fieldmaps was to re-run the SDCFlows fieldmap wrangling function, and then look for precomputed fieldmaps of the relevant IDs.
This will change that ID, making a hard break between pre- and post-change derivatives. One of the ostensible advantages to the fit-transform split was that we can run an improved transform stage on any previous derivatives, so long as the derivatives are queryable.
We would need to strategize an alternative method for finding the appropriate fieldmaps from both new and old derivatives to make this change.
|
I am not sure to fully grasp the challenges here, and I wiped a lot of my memory of why I submitted that PR.
|
When force_fmapless is used on top of self-correcting pepolar bold, the fmapless estimator will get it's name from B0FieldIdentifier, creating a duplicate.
For now I just created a test to replicate that behavior and triggering the error that this PR will try to fix.