Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly#7
Fix Navbar will not hide completely when scroll direction changed & bottomBoundary not count correctly#7xuzhe wants to merge 7 commits intoninjinkun:masterfrom
Conversation
|
Also added any subview of UINavigationBar support (not just customized title view). |
|
Thanks. I will review it on this weekend. |
There was a problem hiding this comment.
I don't understand why you added this interface. I prefer less interface. Please tell me usable situation.
There was a problem hiding this comment.
The interface is notifying the receiver that the user is scrolling to the bottom of UIScrollview.
If you have a toolbar at the bottom and hiding it, the delegate will give you a chance to show the toolbar.
The code to use the interface should like this:
- (void)scrollFullScreen:(NJKScrollFullScreen *)proxy scrollViewOverBottomBarTopBoundary:(CGFloat)deltaY { [self moveNavigtionBar:deltaY animated:YES]; [self moveToolbar:-deltaY animated:YES]; // move to revese direction [self updateToolbarItems]; // Workaround iOS 7's bug: sometime the toolbar items will not be displayed }
|
@xuzhe I reviewed. Your pull request is almost looks good. Please reply to my comments. |
There was a problem hiding this comment.
You broke my indent. Please fix.
There was a problem hiding this comment.
Sorry, Xcode did this for me. I will fix it manually.
|
@xuzhe If you are busy, I'll merge and fix it by myself. I'm waiting for your reply. |
|
I am sorry for the delay in replying. It seems I am not getting Github's notification emails. If there are still any problems, please let me know. |
There was a problem hiding this comment.
Why do you change default? It may confuse previous default users.
|
@xuzhe After re-review, I found problem #7 (comment) . |
|
I am OK, do whatever you want 👍 |
2 participants
No description provided.