Speedup anim import & various other fixes#506
Merged
neomonkeus merged 55 commits intoniftools:developfrom Jun 2, 2022
Merged
Conversation
…same vertices used.
Slight fix for triangle assignment to bodypart on partition import
Import animation by default
neomonkeus
reviewed
Mar 30, 2022
pull out get_keys_values clean up euler import
neomonkeus
reviewed
Mar 30, 2022
pull out maths and type handling into dict
neomonkeus
approved these changes
Mar 30, 2022
Contributor
Author
|
Ah damn, UV anim import is broken, still coded for old tex slots system. Needs upgrade for nodes api. All the other anim imports have been upgraded to the new faster api and tested successfully. |
neomonkeus
reviewed
Mar 30, 2022
neomonkeus
approved these changes
Mar 30, 2022
HENDRIX-ZT2
changed the title
…ity to niftools collision property to fix error caused by changes in Blender 3.0 and later.
Two small fixes including niftools#499
neomonkeus
reviewed
May 21, 2022
Member
neomonkeus
left a comment
neomonkeus
left a comment
There was a problem hiding this comment.
Not sure about moving BSInvMarker from object > scene level.
Rest look good.
- use file name instead of generated name if possible - only extract once per run - fix too long value error for big images
just adds the node but doesn't link it
neomonkeus
reviewed
May 26, 2022
| default='NONE', | ||
| update=update_version_from_game) | ||
|
|
||
| rootnode: EnumProperty( |
Member
There was a problem hiding this comment.
Should this be at scene level?
Member
There was a problem hiding this comment.
Should we have a reference to an object which would used as the root node?
Contributor
Author
There was a problem hiding this comment.
Should we have a reference to an object which would used as the root node?
I think then we just delegate the problem. It's better to tag root objects (eg. those without a parent are automatically root objects)
Member
There was a problem hiding this comment.
I was more thinking in the case that we have multiple objects tags as root object or do we allow that.
neomonkeus
reviewed
Jun 2, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@niftools/blender-niftools-addon-reviewer
Overview
speed up anim keyframe import, the more keys, the more speedup. about 10x on some sample nifs
Detailed Description
Fixes Known Issues
closes #180
closes #495
closes #500
closes #510
closes #517
Documentation
none
Testing
import nif / kf with animated controllers
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]