Updated initWithCoder to correct implementation with proper initializ…#32
Open
apwelsh wants to merge 1 commit intonicklockwood:masterfrom
Open
Updated initWithCoder to correct implementation with proper initializ…#32apwelsh wants to merge 1 commit intonicklockwood:masterfrom
apwelsh wants to merge 1 commit intonicklockwood:masterfrom
Conversation
…er method The initWithCoder method is missing a call to [self init], so I modified the initWithCoder function to adhere to the standard initializer template.
Author
|
I just saw the change log notation that the initWithCoder method no longer calls the init method. Ignore my pull request. But please explain why this was done? |
Owner
|
It's tricky. Ideally it would call |
nicklockwood
force-pushed
the
master
branch
2 times, most recently
from
577f9ba to
e4b098a
Compare
Ellajoke
approved these changes
Aug 1, 2022
Ellajoke
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er method
The initWithCoder method is missing a call to [self init], so I modified the initWithCoder function to adhere to the standard initializer template.