[codex] Preserve live tool history#37
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the agent loop so that tool-call and tool-result information is preserved in the in-memory session.history across turns, allowing subsequent model turns to receive the same tool context that occurred earlier in the session. It also adds multi-turn test coverage to ensure tool history is included in later model requests.
Changes:
- Record assistant tool-call parts and tool-result messages into
session.historyduring streaming turns. - Split assistant history into (a) structured parts for tool calls and (b) trailing plain assistant text, while keeping durable event persistence unchanged.
- Add multi-turn tests to assert that prior tool calls/results (success + failure) are included in later model turns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/agent-core/src/agent.ts | Adds tool-call/tool-result entries to session.history and helper logic to flush/append them during a turn. |
| packages/acp-agent/src/agent-prompt-cancellation.test.ts | Adds regression tests asserting prior tool calls/results are present in later model turn messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #15.
Detailed validation