mark flake8-spellcheck as a rejected plugin#272
Open
mshafer-NI wants to merge 2 commits intoni:mainfrom
Open
Conversation
Contributor
|
Thank you for contributing! 👋 |
bkeryan
approved these changes
Feb 2, 2026
Collaborator
bkeryan
left a comment
There was a problem hiding this comment.
I agree with your assessment. I don't want to have to noqa every magic method or variable that is suffixed with a number.
Co-authored-by: Brad Keryan <brad.keryan@ni.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8-spellcheckappears to not provide much value.The project has not had commits since 2024 (2 years at the time of writing), has open issues and pull requests from 2022, some of which we would want if we were to consider adopting this (e.g., MichaelAquilina/flake8-spellcheck#89 MichaelAquilina/flake8-spellcheck#80 MichaelAquilina/flake8-spellcheck#56 MichaelAquilina/flake8-spellcheck#61 MichaelAquilina/flake8-spellcheck#43, MichaelAquilina/flake8-spellcheck#63)