Skip to content

Add Ok Breakpoint Column#2963

Open
hellovolcano wants to merge 27 commits into
mainfrom
users/vgleason/breakpoint
Open

Add Ok Breakpoint Column#2963
hellovolcano wants to merge 27 commits into
mainfrom
users/vgleason/breakpoint

Conversation

@hellovolcano
Copy link
Copy Markdown
Contributor

@hellovolcano hellovolcano commented May 21, 2026

Pull Request

🤨 Rationale

A client needs a breakpoint column for debugging workflows.
HLD + IxD

👩‍💻 Implementation

This component mimics the nimble menu button component, but in addition to the toggle events on click, also includes a context menu event to allow clients to set additional states.

Added:

  • A fixed width table column
  • toggle events to switch between enabling/adding a breakpoint and removing
  • oncontextmenu events to track right-click/context menu actions
  • BreakpointStateEnum to track states and visual styles for breakpoint states
  • Blazor wrappers and examples

🧪 Testing

manual testing
added unit tests

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI
Copy link
Copy Markdown
Contributor

@hellovolcano, Here's @msmithNI 's innovation day branch for an ok custom column type (aka a square breakpoint column 🟥): main...users/masmith/innovationDay-okTableColumn1

I haven't looked at either implementation but it could be useful to scan it for differences with your approach and ping him with any questions. (Note when we talked I misspoke about who had done this project, it is definitely Malcolm)

@hellovolcano hellovolcano marked this pull request as ready for review May 28, 2026 22:14
@hellovolcano
Copy link
Copy Markdown
Contributor Author

FYI @jattasNI -- I know we originally talked about adding a label provider for ok. I'm open to adding that later, but for this first review I just used stringsin the component itself.

Copy link
Copy Markdown
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the ok-components changes with some rigor (not quite normal Nimble level but more than normal Ok level). Only just skimmed the Blazor changes.

Most of the feedback is nice-to-have for the Ok level with the exception of the tab focus getting stuck on the breakpoint.

Comment thread change/@ni-ok-components-744c8788-8d43-48b6-9bff-7f72757113b5.json
Comment thread packages/ok-components/src/ts/table-column/breakpoint/cell-view/index.ts Outdated
@hellovolcano hellovolcano requested a review from jattasNI June 2, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants