Add Ok Breakpoint Column#2963
Conversation
|
@hellovolcano, Here's @msmithNI 's innovation day branch for an ok custom column type (aka a square breakpoint column 🟥): main...users/masmith/innovationDay-okTableColumn1 I haven't looked at either implementation but it could be useful to scan it for differences with your approach and ping him with any questions. (Note when we talked I misspoke about who had done this project, it is definitely Malcolm) |
|
FYI @jattasNI -- I know we originally talked about adding a label provider for ok. I'm open to adding that later, but for this first review I just used stringsin the component itself. |
jattasNI
left a comment
There was a problem hiding this comment.
Reviewed the ok-components changes with some rigor (not quite normal Nimble level but more than normal Ok level). Only just skimmed the Blazor changes.
Most of the feedback is nice-to-have for the Ok level with the exception of the tab focus getting stuck on the breakpoint.
Co-authored-by: Jesse Attas <jattasNI@users.noreply.github.com>
Pull Request
🤨 Rationale
A client needs a breakpoint column for debugging workflows.
HLD + IxD
👩💻 Implementation
This component mimics the nimble menu button component, but in addition to the toggle events on click, also includes a context menu event to allow clients to set additional states.
Added:
🧪 Testing
manual testing
added unit tests
✅ Checklist