Skip to content

chore(deps): update python packages #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dixonjoel merged 3 commits into from
Jun 1, 2026
Merged

chore(deps): update python packages #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d6e7c
chore(deps): update python packages
renovate[bot] May 31, 2026
7823ca6
Fix ni-python-styleguide errors associated with 0.5.0 version change.
Jun 1, 2026
927f7e2
Fix lint error for ni-python-styleguide 0.5.0.
Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 48 additions & 18 deletions packages/generator/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions packages/service/ni_measurement_plugin_sdk_service/measurement/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
from pathlib import Path
from types import TracebackType
from typing import (
TYPE_CHECKING,
Any,
Callable,
Literal,
TYPE_CHECKING,
TypeVar,
Union,
)
Expand All @@ -34,9 +34,7 @@
SessionManagementClient,
SingleSessionReservation,
)
from ni_grpc_extensions.channelpool import ( # re-export
GrpcChannelPool as GrpcChannelPool,
)
from ni_grpc_extensions.channelpool import GrpcChannelPool # re-export
Copy link
Copy Markdown
Collaborator

@bkeryan bkeryan Jun 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @dixonjoel @mshafer-NI This is a regression. Mypy with --no-implicit-reexport interprets from X import Y as Y as an explicit re-export: https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport

Copy link
Copy Markdown
Collaborator

@mshafer-NI mshafer-NI Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, when we chose to adopt flake8-tidy-imports, we didn't catch that it flags as imports in our testing because ni-python-styleguide (and a lot of our other modules) avoided doing this already...

Copy link
Copy Markdown
Collaborator

@dixonjoel dixonjoel Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is there any action needed here? Or do we just eliminate the 'as blah' to fix any errors this flags?


from ni_measurement_plugin_sdk_service import _datatypeinfo
from ni_measurement_plugin_sdk_service._annotations import (
Expand Down
72 changes: 51 additions & 21 deletions packages/service/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading