This repository was archived by the owner on Jan 10, 2018. It is now read-only.
rename intial probe action from init to probe#256
Open
fxck wants to merge 1 commit intongrx:masterfrom
Open
Conversation
> The first time to probe for an initial state if you did not provide one, the second time when Store is instantiated https://gitter.im/ngrx/store?at=580662f3759f6d2436c41a32
Member
|
Looks like the probing may not be necessary soon. See ReactiveX/rxjs#2050 |
|
Hi , sorry dude, but seriously firing"init" twice makes no sense at all and is extremely confusing/ frightening/ worrying for developers (it was for me at least). Please change one "init" to "probe" and decide later if you want to remove probe (who came up with the name probe anyway lol). |
|
Looks like the RxJs issue was just merged the other day (24th), so we should be all set now. Do we need any changes to implement this? @MikeRyan52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gitter.im/ngrx/store?at=580662f3759f6d2436c41a32