DRAFT: replace crate::net::resolver with ngx::async_::resolver#41
Merged
bavshin-f5 merged 1 commit intonginx:mainfrom Sep 15, 2025
Merged
DRAFT: replace crate::net::resolver with ngx::async_::resolver#41bavshin-f5 merged 1 commit intonginx:mainfrom
bavshin-f5 merged 1 commit intonginx:mainfrom
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
pchickey
force-pushed
the
pch/upstreamed_resolver
branch
from
29d9595 to
b6797fd
Compare
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms |
pchickey
force-pushed
the
pch/upstreamed_resolver
branch
from
b6797fd to
69c430e
Compare
Contributor
Author
|
Rebased on main and using a patch pointing to the upstreamed nginx/ngx-rust#197 which has now landed. I believe this only needs an ngx-rust release before it can merge. |
ngx's resolver started as this crate's resolver, and includes bug fixes
bavshin-f5
force-pushed
the
pch/upstreamed_resolver
branch
from
69c430e to
8c5eacc
Compare
bavshin-f5
approved these changes
Sep 15, 2025
Member
bavshin-f5
left a comment
bavshin-f5
left a comment
There was a problem hiding this comment.
Thanks a lot!
Updated to ngx v0.5.0, should be good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngx's resolver started as this crate's resolver, and includes bug fixes.
Draft until nginx/ngx-rust#197 lands upstream.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).