-
Notifications
You must be signed in to change notification settings - Fork 125
NIC: http-redirect-code ConfigMap key and nginx.org/ssl-redirect annotation #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nic-release-5.4
Are you sure you want to change the base?
Conversation
…nd the nginx.org/ssl-redirect annotation. Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com>
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds documentation for configurable HTTP redirect codes and updates SSL redirect annotation references. The changes enable users to customize the HTTP status code used for HTTPS redirects (supporting 301, 302, 307, 308) via the new http-redirect-code ConfigMap key and nginx.org/http-redirect-code annotation.
Key changes:
- Introduces the
http-redirect-codeConfigMap key to allow customization of HTTP redirect status codes - Updates
nginx.org/ssl-redirectannotation to replace the deprecatedingress.kubernetes.io/ssl-redirect - Clarifies redirect behavior in annotations and ConfigMap documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| content/nic/install/migrate-ingress-nginx.md | Updates migration guide to reference the new nginx.org/ssl-redirect annotation and adds note about nginx.org/redirect-to-https for force-ssl-redirect behavior |
| content/nic/configuration/virtualserver-and-virtualserverroute-resources.md | Adds http-redirect-code to the list of customizable ConfigMap keys for VirtualServer resources |
| content/nic/configuration/ingress-resources/advanced-configuration-with-annotations.md | Documents the new http-redirect-code annotation, updates redirect annotation descriptions, and deprecates ingress.kubernetes.io/ssl-redirect |
| content/nic/configuration/global-configuration/configmap-resource.md | Documents the http-redirect-code ConfigMap key and updates redirect descriptions to reference the new configuration option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
content/nic/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds documentation for the configurable HTTP redirect codes feature and the nginx.org/ssl-redirect annotation.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩