-
Notifications
You must be signed in to change notification settings - Fork 41
Add Orthomarburgvirus marburgense species taxon (taxonId: 3052505) #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Again, not a huge expert on this particular virus, but my usual concern is that the path is too generic: It's like having a flu named just Paths are immutable, global, unique identifiers of datasets and they cannot be nested in the existing dataset paths. So once If any immediate identification or sub-classification groups come to mind, it's better to include them into the path. Or, as a lazy solution, a path segment with ref sequence accession. The usual candidate keywords could be in the readme:
as well as and in the genbank readme: https://www.ncbi.nlm.nih.gov/nuccore/NC_001608.3 If there's only one |
|
@ivan-aksamentov thanks! I renamed to community/genspectrum/marburg/HK1980/all-lineages (H = human, K= Kenya, 1980 = collection date) |
|
I allowed myself to push the rebuild (instead of the bot :) This way we can preview how indexing and autosuggestions work. Also, it is better to test things in this PR, not some other things at a remote location (genspectrum repo), to make sure we test what we have here, not there: At this point LGTM, but I'll let science team to do the final decision and merge if all good. |
|
LGTM. happy to see that the clade founder thing works! |

This is a copy of a dataset I created here: GenSpectrum/nextclade-datasets#4
You can view the dataset by running
The example sequences:
data/marburg/unreleased/sequences.fastaare a subsample of 20 marburg sequences with over 10% coverage.I also added clades and lineages:

Example sequences fall with their corresponding sequence in the tree:

Tree built here:
https://github.com/anna-parker/marburg-virus-tree/tree/main