Update mermaid to v11 (with promises)#748
Open
mathpunk wants to merge 1 commit intonextjournal:mainfrom
Open
Conversation
Author
|
I should add, this is undertested: I don't know what the setup environment for base clerk is. I've always just cloned the clerk-demo and then hacked out the bits I don't need. |
Author
|
Hmmmm I restarted my machine and now it looks like I can only get v10 and earlier. There's something I must not understand about caching, either in my notebook or in jsdelivr. I'm hoping that the promise code is still helpful but I'm unclear how to fix the invalid module error I'm getting if I use something later than about 10.3. |
7f228ff to
31fbb98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have I ever made pull request to an open source repo? 🤔
I looked for all uses of this version of a Mermaid renderer and made 3 copies of that change. That duplication might not be desirable. Also it is LLM-enhanced code, you might not like the style or the error handling. But! I'll make any changes you like, or someone who has more mature maintainer skillz is welcome to build on this. The chat that led to my solution is here.