Skip to content

fix(notifications): Update notifier exception handling #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickvergessen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(notifications): Update notifier exception handling #681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
use OCP\Notification\IDismissableNotifier;
use OCP\Notification\INotification;
use OCP\Notification\INotifier;
use OCP\Notification\UnknownNotificationException;
use OCP\Share\Events\ShareCreatedEvent;
use OCP\Share\IShare;

Expand Down Expand Up @@ -102,7 +103,7 @@
}

public function prepare(INotification $notification, string $languageCode): INotification {
throw new \InvalidArgumentException();
throw new UnknownNotificationException();

Check failure on line 106 in lib/Listener.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis dev-stable29

UndefinedClass 

lib/Listener.php:106:13: UndefinedClass: Class, interface or enum named OCP\Notification\UnknownNotificationException does not exist (see https://psalm.dev/019)
Copy link
Member Author

@nickvergessen nickvergessen Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to drop Nextcloud 29?

}

public function dismissNotification(INotification $notification): void {
Expand Down
Loading