fix(drafts): preserve Bcc header when saving drafts#13182
Open
ChristophWurst wants to merge 2 commits into
Open
fix(drafts): preserve Bcc header when saving drafts#13182ChristophWurst wants to merge 2 commits into
ChristophWurst wants to merge 2 commits into
Conversation
ChristophWurst
force-pushed
the
fix/bcc-draft
branch
from
5131f35 to
d06dbf7
Compare
madbob
reviewed
Jul 7, 2026
| return [$account, $draftsMailbox, $newUid]; | ||
| } | ||
|
|
||
| private function buildMimeHeaders(Address $from, AddressList $to, AddressList $cc, AddressList $bcc, ?string $subject): Horde_Mime_Headers { |
Collaborator
There was a problem hiding this comment.
This new function replaces entirely buildHeaders(), which is no longer used and can be suppressed.
Member
Author
There was a problem hiding this comment.
Good catch! Missed because I opened this PR when #13180 wasn't in either.
Horde_Mime_Mail::getRaw() omits the Bcc header (same root cause as the sent mailbox fix). Reopening a saved draft therefore lost all Bcc recipients silently. Add buildMimeHeaders() returning Horde_Mime_Headers directly, and use $mail->getBasePart()->toString() with those headers instead of $mail->getRaw() in saveLocalDraft() and saveDraft(). Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/bcc-draft
branch
from
d06dbf7 to
888ef94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat related to #13180.
How to test
main: empty Bcc
here: restored Bcc
🤖 AI (if applicable)