Conversation
0a16060 to
ec9f3f6
Compare
ec9f3f6 to
87aaffa
Compare
There was a problem hiding this comment.
- Could you describe more what the change actually is? It would make it easier to navigate in the diff.
- After switching to this branch and reloading the settings, i get
Is it expected?
- It is not clear what is specific to the selected context and what is global. It might help to group what is context-specific or add an indicator next to each of those fields.
- Maybe it's more explicit or easy to follow for the users if there are 4 "service" blocks: a global one, one for image gen, one for tts, one for stt. Each block would be placed in the related section.
|
julien-nc
left a comment
There was a problem hiding this comment.
I think we still need to clarify what is impacted by switching contexts. Either a visual clue of an explanation text in a note card.
We should mention that text generation is necessarily configured with the default context.
| } else { | ||
| $serviceName = $this->openAiSettingsService->getServiceName(); | ||
| if ($serviceType === 'image' && $this->openAiSettingsService->imageOverrideEnabled()) { | ||
| $serviceName = $this->openAiSettingsService->getImageServiceName(); |
There was a problem hiding this comment.
If it's an override (the override URL is defined) it does not mean the service name is defined. We should probably fall back to the default one. Wdyt?
There was a problem hiding this comment.
I'm not sure. It does fallback to LocalAI if a service name isn't defined and I think that is a better default than the service name of the text processing provider.
There was a problem hiding this comment.
Ok then let's change the fallback. Instead of LocalAI it could be something more generic like OpenAI/LocalAI integration.
There was a problem hiding this comment.
It does detect OpenAI automatically, so OpenAI/LocalAI probably isn't the best name. I can't think of a better one though.
dba53a3 to
826cbbf
Compare
julien-nc
left a comment
There was a problem hiding this comment.
This is much better visually and logically 👍
Small change suggestion, otherwise let's go.
| } else { | ||
| $serviceName = $this->openAiSettingsService->getServiceName(); | ||
| if ($serviceType === 'image' && $this->openAiSettingsService->imageOverrideEnabled()) { | ||
| $serviceName = $this->openAiSettingsService->getImageServiceName(); |
There was a problem hiding this comment.
Ok then let's change the fallback. Instead of LocalAI it could be something more generic like OpenAI/LocalAI integration.
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
dc0ded3 to
845e910
Compare






Simple Overview

Adds hidden menus for override in the ui. When you select a different context you can specify settings for that context otherwise the default will be used.
Description