Skip to content

feat(assistant): translate#16326

Merged
alperozturk96 merged 25 commits intomasterfrom
feat/translate-task-type
Feb 4, 2026
Merged

feat(assistant): translate#16326
alperozturk96 merged 25 commits intomasterfrom
feat/translate-task-type

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 20, 2026 •
edited
Loading

  • Tests written, or not not needed

Implements second part of it: nextcloud/files-clients#89 (comment)

Library PR: nextcloud/android-library#1933

@alperozturk96 alperozturk96 requested a review from kra-mo January 20, 2026 15:04
@alperozturk96 alperozturk96 marked this pull request as draft January 20, 2026 15:04
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 68b8c32 to 61bf192 Compare January 21, 2026 09:55
@alperozturk96 alperozturk96 marked this pull request as ready for review January 21, 2026 09:56
@alperozturk96 alperozturk96 marked this pull request as draft January 21, 2026 09:56
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 4ecd0e2 to 2842d25 Compare January 21, 2026 10:01
@alperozturk96 alperozturk96 force-pushed the feat/action-process-text-support branch from 77ffc2b to 5eeae80 Compare January 21, 2026 10:14
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 2 times, most recently from 6e7c54b to 747223e Compare January 21, 2026 11:29
Base automatically changed from feat/action-process-text-support to master January 21, 2026 13:36
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from f5f80f6 to 1bd9a81 Compare January 21, 2026 13:42
@nimishavijay
Copy link
Member

nimishavijay commented Jan 21, 2026 •
edited by alperozturk96
Loading

Good question. It seems very cumbersome to read long text in this half-screen-scrolling UI. I am assuming that most people will paste the text from somewhere else, in which case the specifics of the original text doesn't matter much. We can just keep the header bar sticky and scroll the rest like usual.

Other than that, 2 small points:

  • "Source language" seems a bit technical, we can change that to "Translate from"
  • It is not obvious from the UI that there is a dropdown for the languages, so we should add a small chevron-down icon next to the language.
  • There's also a floating button and I am not sure what it does (is it a button to force translation or create a "new translation task"?). would it be possible to just automatically translate whenever the source text changes (maybe throttled to 500ms or something to avoid sending too many requests)?

@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 0860e36 to f158729 Compare January 22, 2026 09:20
@alperozturk96 alperozturk96 marked this pull request as ready for review January 22, 2026 14:21
@alperozturk96

This comment was marked as resolved.

Sign in to view
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 4489c04 to 4b1aae2 Compare January 22, 2026 15:04
kra-mo

This comment was marked as resolved.

Sign in to view

@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 4b1aae2 to 9ce6c24 Compare January 23, 2026 14:31
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch 3 times, most recently from 01d407c to d586a61 Compare January 27, 2026 12:30
@alperozturk96 alperozturk96 requested a review from kra-mo January 27, 2026 14:34
@alperozturk96
add translation model
dab2c20 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
f52a0a4 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/res/values/strings.xml
@alperozturk96
add translation logic
a6ebfd5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
d3c4155 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation logic
d36b9b1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation task select
664521c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix layout update
814a5df 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix layout update
1508f93 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
handle task select
3ecd1b7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
handle task select
2644578 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
673091b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
8cd39cf 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix translation flow
9df7a36 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
9223242 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
4f38e82 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
41c89a7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
better ui ux
d3bd7b5 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add polling for task selection
3e3a0d8 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
d216afd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
dd2b09a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix ux
23aec6f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.36.0 milestone Feb 4, 2026
@alperozturk96
update android library
d1115bd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feat/translate-task-type branch from 7bfc65d to d1115bd Compare February 4, 2026 08:26
@alperozturk96 alperozturk96 merged commit 86482e7 into master Feb 4, 2026
11 of 20 checks passed
@alperozturk96 alperozturk96 deleted the feat/translate-task-type branch February 4, 2026 08:27
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16326.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kra-mo kra-mo kra-mo approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @nimishavijay @kra-mo