Skip to content

Albums functionality #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
surinder-tsys wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Albums functionality #14947

surinder-tsys wants to merge 14 commits into from

Conversation

@surinder-tsys
Copy link
Collaborator

@surinder-tsys surinder-tsys commented Jun 2, 2025 •
edited
Loading

This PR contains the new Albums Functionality.

Library PR: nextcloud/android-library#1736

  • Tests written, or not not needed

@surinder-tsys surinder-tsys force-pushed the nmc/albums branch 2 times, most recently from a42a89f to 237cbfa Compare June 2, 2025 13:44
@surinder-tsys surinder-tsys mentioned this pull request Jun 2, 2025
Open
@surinder-tsys
Copy link
Collaborator Author

surinder-tsys commented Jun 6, 2025

Hi, @alperozturk96 there is one issue which I couldn't able to fix it. When we open Album images in preview then they don't open in proper order. Because while swiping the images which are not in current Album also shows up.
There must be something in PreviewImageActivity due to which it loads all Images.
Can you help me out how we can fix it? Do I have to create a separate Preview activity for Albums or I can utilize the existing one?

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@surinder-tsys surinder-tsys force-pushed the nmc/albums branch 3 times, most recently from f242064 to 60a23de Compare July 10, 2025 09:19
@tobiasKaminsky tobiasKaminsky mentioned this pull request Feb 25, 2025
Open
2 tasks
@surinder-tsys surinder-tsys force-pushed the nmc/albums branch 3 times, most recently from 7ad15b8 to dc27bf9 Compare January 22, 2026 18:02
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code256259
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total479482

SpotBugs increased!

alperozturk96
alperozturk96 requested changes Jan 27, 2026
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

Thank you for the PR.

app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt
/** 1. check copy validity */
val result: RemoteOperationResult<Any>

if (targetParentPath.startsWith(srcPath)) {
Copy link
Collaborator

@alperozturk96 alperozturk96 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

srcPath = "/Photos/Vacation"
targetParentPath = "/Photos/Vacation2025"

In this case first if check will be true and we will block valid copy operation.

Copy link
Collaborator Author

@surinder-tsys surinder-tsys Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with same path and works. This will not fail or block the operation because in our case targetParentPath will be album name "Vacation2025" not the full path.
Internally we are appending /albums/{targetParentPath} : https://github.com/nextcloud/android-library/pull/1736/changes#diff-1c2582f40935505ddfd39bbb11242f8bcb944bf801a70800533f8aa9907ab610R56

surinder-tsys and others added 9 commits January 29, 2026 20:32
@surinder-tsys
Albums functionality.
6f8276a 
Signed-off-by: A117870935 <surinder.kumar@t-systems.com>
@surinder-tsys
Rename .java to .kt
6453d01 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
Code refactoring and operation migrated to kotlin
52e42b8 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
Fix -> video click event, overflow menu item hide and theming add menu
335bef7 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
Fix: preview album items
c95ae76 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
upload files to album, hide video overlay icon, minor ui and bug fixes
eb76f2d 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@tobiasKaminsky @surinder-tsys
wip
a4a6426 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@surinder-tsys
Albums functionality.
35011ff 
Signed-off-by: A117870935 <surinder.kumar@t-systems.com>
@surinder-tsys
Rename .java to .kt
b79896a 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
surinder-tsys and others added 5 commits January 29, 2026 20:41
@surinder-tsys
Code refactoring and operation migrated to kotlin
9cba0ff 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
upload files to album, hide video overlay icon, minor ui and bug fixes
c04efe9 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@tobiasKaminsky @surinder-tsys
small fix
4137454 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@surinder-tsys
code fixes
b20debe 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@surinder-tsys
album upload worker state handled via localbroadcastmanager
a2639b6 
Signed-off-by: Surinder Kumar <surinder.kumar@t-systems.com>
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14947.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review enhancement feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@surinder-tsys @alperozturk96 @AndyScherzinger @tobiasKaminsky