Merged
Conversation
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
b59f39c to
7599117
Compare
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
7599117 to
dd0b8a8
Compare
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
dd0b8a8 to
509ed3c
Compare
Contributor
tobiasKaminsky
force-pushed
the
recommendations
branch
from
509ed3c to
ee5ba44
Compare
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
ee5ba44 to
7cf2a1e
Compare
Contributor
tobiasKaminsky
force-pushed
the
recommendations
branch
from
7cf2a1e to
31387df
Compare
Contributor
tobiasKaminsky
force-pushed
the
recommendations
branch
from
31387df to
231101b
Compare
Contributor
Contributor
alperozturk96
previously approved these changes
Jan 8, 2025
tobiasKaminsky
force-pushed
the
recommendations
branch
from
0332e9a to
a0c49a3
Compare
Contributor
Contributor
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
f0410e0 to
b967bf6
Compare
alperozturk96
approved these changes
Jan 17, 2025
Contributor
alperozturk96
requested changes
Jan 20, 2025
Contributor
There was a problem hiding this comment.
@tobiasKaminsky Could you add capability for the recommendation so that client dont do unnecessary network calls?
com.owncloud.android.lib.resources.status.OCCapability
Contributor
alperozturk96
force-pushed
the
recommendations
branch
from
0bfd504 to
cda932b
Compare
Contributor
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3793-IT-master-11-02/debug/ |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
recommendations
branch
from
cda932b to
142588c
Compare
Contributor
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3807-IT-master-11-00/debug/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs: nextcloud/recommendations#829
Part of nextcloud/android#14167