Harmindar update#6
Open
usaygij wants to merge 6 commits into
Open
Conversation
vivekpathak
reviewed
Nov 20, 2019
| logger.error("failed to insert " + query) | ||
| -1 | ||
| DatabaseError.ConstraintViolation | ||
| } |
vivekpathak
reviewed
Nov 20, 2019
| val rs: ResultSet = statement.executeQuery(query) | ||
| val rs: ResultSet = | ||
| getConnection.createStatement(ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY).executeQuery(query) | ||
| if (!rs.first()) { |
Contributor
There was a problem hiding this comment.
comment on flags being used - what is the intention
vivekpathak
reviewed
Nov 20, 2019
| p.opening_ts after new Date() | ||
| } | ||
| def deletePoll(): Int = { | ||
| def deletePoll(): Any = { |
Contributor
There was a problem hiding this comment.
Type should not be made Any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Enum code with test cases, replaced arbitrary constant values with enum values.