Migrate to SvelteKit remote functions#38
Open
nevthereal wants to merge 2 commits into
Open
Conversation
- Replace page/server actions with remote modules - Update SvelteKit and related dependencies - Remove obsolete drizzle migration files and form helpers
- Remove client-side `.updates(...)` calls in favor of remote refreshes - Move club join handling into a server load route and use 303 redirects - Update challenge navigation to use resolved paths
Contributor
📝 WalkthroughWalkthroughThis pull request removes all database migration files and schema snapshots from the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@AGENTS.md`:
- Around line 9-11: Update AGENTS.md to clarify that the opensrc/ directory (and
opensrc/sources.json) may be missing in fresh clones and add a clear
bootstrap/fallback section instructing agents to (1) run the provided bootstrap
script or command (mention the repository's bootstrap script name if present,
e.g., bootstrap.sh or setup.sh) or (2) fetch the canonical sources.json from the
project’s upstream URL or create a minimal sources.json with required package
entries before proceeding; reference opensrc/ and opensrc/sources.json
explicitly and show the exact fallback commands/URLs or the minimal JSON
structure to use.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0230efae-6849-4a29-ae41-80502e66f393
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (145)
.gitignoreAGENTS.mddrizzle/0000_luxuriant_the_hand.sqldrizzle/0001_nervous_talos.sqldrizzle/0002_gigantic_hawkeye.sqldrizzle/0003_late_vin_gonzales.sqldrizzle/0004_minor_toad.sqldrizzle/0005_even_doorman.sqldrizzle/0006_uneven_adam_warlock.sqldrizzle/0007_nebulous_flatman.sqldrizzle/0008_big_christian_walker.sqldrizzle/0009_low_mac_gargan.sqldrizzle/0010_normal_jigsaw.sqldrizzle/0011_wide_madame_masque.sqldrizzle/0012_fast_prima.sqldrizzle/0013_parched_rachel_grey.sqldrizzle/0014_parallel_christian_walker.sqldrizzle/0015_free_rattler.sqldrizzle/0016_secret_sir_ram.sqldrizzle/0017_yellow_synch.sqldrizzle/0018_absent_skaar.sqldrizzle/0019_premium_tomas.sqldrizzle/0020_young_skrulls.sqldrizzle/0021_fancy_midnight.sqldrizzle/0022_fixed_captain_cross.sqldrizzle/0023_faulty_the_hood.sqldrizzle/0024_exotic_madame_hydra.sqldrizzle/meta/0000_snapshot.jsondrizzle/meta/0001_snapshot.jsondrizzle/meta/0002_snapshot.jsondrizzle/meta/0003_snapshot.jsondrizzle/meta/0004_snapshot.jsondrizzle/meta/0005_snapshot.jsondrizzle/meta/0006_snapshot.jsondrizzle/meta/0007_snapshot.jsondrizzle/meta/0008_snapshot.jsondrizzle/meta/0009_snapshot.jsondrizzle/meta/0010_snapshot.jsondrizzle/meta/0011_snapshot.jsondrizzle/meta/0012_snapshot.jsondrizzle/meta/0013_snapshot.jsondrizzle/meta/0014_snapshot.jsondrizzle/meta/0015_snapshot.jsondrizzle/meta/0016_snapshot.jsondrizzle/meta/0017_snapshot.jsondrizzle/meta/0018_snapshot.jsondrizzle/meta/0019_snapshot.jsondrizzle/meta/0020_snapshot.jsondrizzle/meta/0021_snapshot.jsondrizzle/meta/0022_snapshot.jsondrizzle/meta/0023_snapshot.jsondrizzle/meta/0024_snapshot.jsondrizzle/meta/_journal.jsone2e/demo.test.tspackage.jsonsrc/app.csssrc/lib/components/DisciplineForm.sveltesrc/lib/components/EntryCard.sveltesrc/lib/components/EntryForm.sveltesrc/lib/components/Leaderboard.sveltesrc/lib/components/ui/alert-dialog/index.tssrc/lib/components/ui/badge/index.tssrc/lib/components/ui/button/index.tssrc/lib/components/ui/calendar/index.tssrc/lib/components/ui/card/index.tssrc/lib/components/ui/chart/chart-container.sveltesrc/lib/components/ui/chart/chart-utils.tssrc/lib/components/ui/chart/index.tssrc/lib/components/ui/command/index.tssrc/lib/components/ui/data-table/data-table.svelte.tssrc/lib/components/ui/data-table/index.tssrc/lib/components/ui/data-table/render-helpers.tssrc/lib/components/ui/dialog/index.tssrc/lib/components/ui/dropdown-menu/index.tssrc/lib/components/ui/field/field-description.sveltesrc/lib/components/ui/field/field-error.sveltesrc/lib/components/ui/field/field-group.sveltesrc/lib/components/ui/field/field-label.sveltesrc/lib/components/ui/field/field-legend.sveltesrc/lib/components/ui/field/field-separator.sveltesrc/lib/components/ui/field/field-set.sveltesrc/lib/components/ui/field/field.sveltesrc/lib/components/ui/field/index.tssrc/lib/components/ui/form/form-button.sveltesrc/lib/components/ui/form/form-description.sveltesrc/lib/components/ui/form/form-element-field.sveltesrc/lib/components/ui/form/form-field-errors.sveltesrc/lib/components/ui/form/form-field.sveltesrc/lib/components/ui/form/form-fieldset.sveltesrc/lib/components/ui/form/form-label.sveltesrc/lib/components/ui/form/form-legend.sveltesrc/lib/components/ui/form/index.tssrc/lib/components/ui/input-otp/index.tssrc/lib/components/ui/input/index.tssrc/lib/components/ui/label/index.tssrc/lib/components/ui/popover/index.tssrc/lib/components/ui/range-calendar/index.tssrc/lib/components/ui/select/index.tssrc/lib/components/ui/separator/index.tssrc/lib/components/ui/sheet/index.tssrc/lib/components/ui/skeleton/index.tssrc/lib/components/ui/sonner/index.tssrc/lib/components/ui/sonner/sonner.sveltesrc/lib/components/ui/spinner/index.tssrc/lib/components/ui/table/index.tssrc/lib/components/ui/tabs/index.tssrc/lib/components/ui/tooltip/index.tssrc/lib/remote/challenges.remote.tssrc/lib/remote/clubs.remote.tssrc/lib/remote/profile.remote.tssrc/lib/remote/session.remote.tssrc/lib/server/request-user.tssrc/lib/zod.tssrc/routes/+layout.server.tssrc/routes/+layout.sveltesrc/routes/+page.server.tssrc/routes/+page.sveltesrc/routes/clubs/+layout.server.tssrc/routes/clubs/+page.server.tssrc/routes/clubs/+page.sveltesrc/routes/clubs/[clubId]/+page.server.tssrc/routes/clubs/[clubId]/+page.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/+layout.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/+layout.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/+page.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/+page.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/activity/+page.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/activity/+page.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/disciplines/+page.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/disciplines/+page.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/members/+page.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/members/+page.sveltesrc/routes/clubs/[clubId]/challenge/[challengeId]/members/[memberId]/+page.server.tssrc/routes/clubs/[clubId]/challenge/[challengeId]/members/[memberId]/+page.sveltesrc/routes/clubs/create/+page.server.tssrc/routes/clubs/create/+page.sveltesrc/routes/clubs/join/+page.server.tssrc/routes/clubs/join/+page.sveltesrc/routes/clubs/join/[code]/+page.server.tssrc/routes/clubs/join/[code]/+page.sveltesrc/routes/profile/+page.server.tssrc/routes/profile/+page.sveltesrc/routes/profile/edit/+page.server.tssrc/routes/profile/edit/+page.sveltesvelte.config.js
💤 Files with no reviewable changes (49)
- drizzle/0013_parched_rachel_grey.sql
- drizzle/0004_minor_toad.sql
- drizzle/0017_yellow_synch.sql
- drizzle/0006_uneven_adam_warlock.sql
- drizzle/0014_parallel_christian_walker.sql
- drizzle/0003_late_vin_gonzales.sql
- drizzle/0021_fancy_midnight.sql
- drizzle/0009_low_mac_gargan.sql
- drizzle/0023_faulty_the_hood.sql
- drizzle/0024_exotic_madame_hydra.sql
- drizzle/0018_absent_skaar.sql
- drizzle/0001_nervous_talos.sql
- drizzle/0005_even_doorman.sql
- drizzle/0019_premium_tomas.sql
- drizzle/0016_secret_sir_ram.sql
- drizzle/meta/0000_snapshot.json
- drizzle/0011_wide_madame_masque.sql
- drizzle/0007_nebulous_flatman.sql
- drizzle/meta/0007_snapshot.json
- drizzle/meta/0001_snapshot.json
- drizzle/meta/0015_snapshot.json
- drizzle/0002_gigantic_hawkeye.sql
- drizzle/meta/0003_snapshot.json
- drizzle/0015_free_rattler.sql
- drizzle/0008_big_christian_walker.sql
- drizzle/meta/0006_snapshot.json
- drizzle/meta/0019_snapshot.json
- drizzle/meta/0005_snapshot.json
- drizzle/meta/0004_snapshot.json
- drizzle/meta/0022_snapshot.json
- drizzle/meta/0018_snapshot.json
- drizzle/meta/0011_snapshot.json
- drizzle/0010_normal_jigsaw.sql
- drizzle/meta/0017_snapshot.json
- drizzle/0022_fixed_captain_cross.sql
- drizzle/meta/0023_snapshot.json
- drizzle/meta/0008_snapshot.json
- drizzle/0000_luxuriant_the_hand.sql
- drizzle/meta/0012_snapshot.json
- drizzle/meta/0009_snapshot.json
- drizzle/meta/0020_snapshot.json
- drizzle/meta/0014_snapshot.json
- drizzle/meta/0002_snapshot.json
- drizzle/meta/0021_snapshot.json
- drizzle/meta/0016_snapshot.json
- drizzle/meta/0013_snapshot.json
- drizzle/0020_young_skrulls.sql
- drizzle/0012_fast_prima.sql
- drizzle/meta/0010_snapshot.json
Comment on lines
+9
to
+11
| Source code for dependencies is available in `opensrc/` for deeper understanding of implementation details. | ||
|
|
||
| See `opensrc/sources.json` for the list of available packages and their versions. |
Contributor
There was a problem hiding this comment.
Clarify that opensrc/ may be absent in fresh clones.
AGENTS.md currently reads as if opensrc/sources.json is always present, but opensrc/ is now gitignored. Add an explicit bootstrap/fallback step so agents know how to proceed when the directory is missing.
📝 Suggested doc adjustment
-Source code for dependencies is available in `opensrc/` for deeper understanding of implementation details.
-
-See `opensrc/sources.json` for the list of available packages and their versions.
+Source code for dependencies can be stored in `opensrc/` for deeper understanding of implementation details.
+
+If `opensrc/` is missing (e.g., fresh clone), fetch what you need with `npx opensrc ...`.
+When present, see `opensrc/sources.json` for the list of available packages and their versions.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Source code for dependencies is available in `opensrc/` for deeper understanding of implementation details. | |
| See `opensrc/sources.json` for the list of available packages and their versions. | |
| Source code for dependencies can be stored in `opensrc/` for deeper understanding of implementation details. | |
| If `opensrc/` is missing (e.g., fresh clone), fetch what you need with `npx opensrc ...`. | |
| When present, see `opensrc/sources.json` for the list of available packages and their versions. |
🧰 Tools
🪛 LanguageTool
[style] ~9-~9: Consider a different adjective to strengthen your wording.
Context: ...ndencies is available in opensrc/ for deeper understanding of implementation details...
(DEEP_PROFOUND)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@AGENTS.md` around lines 9 - 11, Update AGENTS.md to clarify that the opensrc/
directory (and opensrc/sources.json) may be missing in fresh clones and add a
clear bootstrap/fallback section instructing agents to (1) run the provided
bootstrap script or command (mention the repository's bootstrap script name if
present, e.g., bootstrap.sh or setup.sh) or (2) fetch the canonical sources.json
from the project’s upstream URL or create a minimal sources.json with required
package entries before proceeding; reference opensrc/ and opensrc/sources.json
explicitly and show the exact fallback commands/URLs or the minimal JSON
structure to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+page.server.tsactions/load flows to SvelteKit remote functions with server-driven refreshes.Testing
bun db:push --force.Summary by CodeRabbit
Documentation
Chores