Feat: Allow web interface to serve content behind an optional URL path prefix#1124
Open
ngearhart wants to merge 2 commits intoneuvector:mainfrom
Open
Feat: Allow web interface to serve content behind an optional URL path prefix#1124ngearhart wants to merge 2 commits intoneuvector:mainfrom
ngearhart wants to merge 2 commits intoneuvector:mainfrom
Conversation
…path prefix Signed-off-by: Noah Gearhart <noah.gearhart@darkwolfsolutions.com>
Signed-off-by: Noah Gearhart <noah.gearhart@darkwolfsolutions.com>
Author
|
I want to add that I am not married to the environment variable being named |
|
I am the other person ngearhart was talking about. My suggestion was BASE_PATH. And there are other alternatives like RELATIVE_PATH, etc. Just depends on what the reviewers prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Neuvector UI (manager) requires all traffic to be hosted at the root URL behind an FQDN. Although this fits most deployment scenarios, some users (me included) need to route traffic based on URL path prefixes. For example, instead of hosting at "https://neuvector.example.com/", I use "https://example.com/neuvector/".
This PR adds the necessary scaffolding to support a path prefix as described using the optional
PATH_PREFIXenvironment variable. If unset, the Neuvector manager will continue to work as previous, serving at the root URL.This environment variable must not contain a preceding slash.
To test, simply set the environment variable in your environment, and navigate to that new path (for example, if you usually navigate to
http://localhost:8443, set the var totest-pathand navigate tohttp://localhost:8443/test-path/).