Fixed version comparing on conditional model import #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi, I'd also be interested in having this merged. Hopefully there are no complications. Thanks! |
wmfgerrit
pushed a commit
to wikimedia/operations-software-netbox-deploy
that referenced
this pull request
Oct 13, 2022
Through copying it to the -deploy directory and applying manually the needed change (see PR bellow). Adapting freeze_requirements.sh accordingly so it's included in the wheels. Ideally only temporarily the time to check that it's working fine. Longer term is either networktocode/ntc-netbox-plugin-metrics-ext#22 gets merged and a new pypi is released. Or we decide to maintain our own fork. Bug: T311052 Change-Id: I31a347a29d7b1e8c2e5d75eaaa0828890bbbf8af
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Version comparision did not allow any major version above 2 with minor versions below 9, so e.g. 3.0.0