Improve logging #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophlehmann
commented
Jan 24, 2024
christophlehmann
commented
- Use static serviceContext as "source". What else should it be?
- Get rid of "PHP Warning" and introduce severity with "error"
- Remove "context", because every field is context.
- Drop the stacktrace, because it too very long (line gets cut off in Loki)
- Add additionalData. Our Sentry Client could then pass its EventId with it.
added 3 commits
January 24, 2024 20:16
* Use static serviceContext as "source". What else should it be? * Get rid of "PHP Warning" and introduce severity with "error" * Remove "context", because every field is context. * Drop the stacktrace, because it too very long (line gets cut off in Loki) * Add additionalData. Our Sentry Client could then pass its EventId with it.
christophlehmann
force-pushed
the
simplify-logging
branch
from
729e03f to
5a5b73e
Compare
hlubek
pushed a commit
that referenced
this pull request
Feb 9, 2026
Lines get cut off, so most important part - the message - is not logged. * Turn stacktrace logging off by default * re-order fields by importance Resolves: #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.