CDP neighbors: Key result on local interface, instead of remote host#134
Open
hvanderheide wants to merge 1 commit intonetwork-unit-testing-system:mainfrom
Open
CDP neighbors: Key result on local interface, instead of remote host#134hvanderheide wants to merge 1 commit intonetwork-unit-testing-system:mainfrom
hvanderheide wants to merge 1 commit intonetwork-unit-testing-system:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of the "show cdp neighbors" command is currently keyed by the remote hostname. This will cause issues when there is a redundant path between two hosts, as the same key can't hold two interfaces/connections.
This PR changes the key to the local interface, similar to the NAPALM LLDP tests. The assertions have grown a little more complex to keep the same "interface" and not break existing test bundles.