Skip to content

Optimize ACL rule table columns #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alehaa wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Optimize ACL rule table columns #271

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e890f90
Linkify ACL rule prefixes
alehaa Aug 17, 2025
bd9ffe7
Render ACL rule ports correctly
alehaa Aug 17, 2025
84773bc
Merge branch 'dev' into feature/linked-acl-rule-tables
alehaa Dec 31, 2025
d3fa594
Hide tags column by default
alehaa Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 31 additions & 38 deletions netbox_acls/tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from django.utils.translation import gettext_lazy as _
from netbox.tables import NetBoxTable, columns

from .models import AccessList, ACLExtendedRule, ACLAssignment, ACLStandardRule
from .models import AccessList, ACLAssignment, ACLExtendedRule, ACLStandardRule

__all__ = (
"AccessListTable",
Expand Down Expand Up @@ -58,7 +58,6 @@ class Meta(NetBoxTable.Meta):
"type",
"rule_count",
"default_action",
"tags",
)


Expand Down Expand Up @@ -114,13 +113,12 @@ class Meta(NetBoxTable.Meta):
"type",
"assigned_object",
"direction",
"tags",
)


class ACLStandardRuleTable(NetBoxTable):
class ACLRuleTable(NetBoxTable):
"""
Defines the table view for the ACLStandardRule model.
Abstract table for all ACL rules.
"""

access_list = tables.Column(
Expand All @@ -130,9 +128,6 @@ class ACLStandardRuleTable(NetBoxTable):
linkify=True,
)
action = columns.ChoiceFieldColumn()
tags = columns.TagColumn(
url_name="plugins:netbox_acls:aclstandardrule_list",
)

# Source
source_type = columns.ContentTypeColumn(
Expand All @@ -145,7 +140,6 @@ class ACLStandardRuleTable(NetBoxTable):
)

class Meta(NetBoxTable.Meta):
model = ACLStandardRule
fields = (
"pk",
"id",
Expand All @@ -156,42 +150,41 @@ class Meta(NetBoxTable.Meta):
"tags",
"description",
"source",
"source_type",
)
default_columns = (
"access_list",
"index",
"action",
"remark",
"source",
"tags",
)


class ACLExtendedRuleTable(NetBoxTable):
class ACLStandardRuleTable(ACLRuleTable):
"""
Defines the table view for the ACLExtendedRule model.
Defines the table view for the ACLStandardRule model.
"""

access_list = tables.Column(
linkify=True,
)
index = tables.Column(
linkify=True,
)
action = columns.ChoiceFieldColumn()
tags = columns.TagColumn(
url_name="plugins:netbox_acls:aclextendedrule_list",
url_name="plugins:netbox_acls:aclstandardrule_list",
)

class Meta(ACLRuleTable.Meta):
model = ACLStandardRule


class ACLExtendedRuleTable(ACLRuleTable):
"""
Defines the table view for the ACLExtendedRule model.
"""

protocol = columns.ChoiceFieldColumn()

# Source
source_type = columns.ContentTypeColumn(
verbose_name=_("Source Type"),
)
source = tables.Column(
verbose_name=_("Source"),
orderable=False,
linkify=True,
source_ports = columns.ArrayColumn(
verbose_name=_("Source Ports"),
empty_values=([],),
)

# Destination
Expand All @@ -203,21 +196,22 @@ class ACLExtendedRuleTable(NetBoxTable):
orderable=False,
linkify=True,
)
destination_ports = columns.ArrayColumn(
verbose_name=_("Destination Ports"),
empty_values=([],),
)

class Meta(NetBoxTable.Meta):
tags = columns.TagColumn(
url_name="plugins:netbox_acls:aclextendedrule_list",
)

class Meta(ACLRuleTable.Meta):
model = ACLExtendedRule
fields = (
"pk",
"id",
"access_list",
"index",
"action",
"remark",
"tags",
"description",
"source",
*(ACLRuleTable.Meta.fields),
"source_ports",
"destination",
"destination_type",
"destination_ports",
"protocol",
)
Expand All @@ -231,5 +225,4 @@ class Meta(NetBoxTable.Meta):
"source_ports",
"destination",
"destination_ports",
"tags",
)
Loading