#42 added color option to ConsoleOutLoggerFactoryAdapter

[adamralph]

fixes #42 using the 'new constructor for ConsoleOutLoggerFactoryAdapter' solution

[adamralph]

Hold off merging for now. I've just realised this implementation is flawed. I'll update the PR later.

[adamralph]

OK, I've replaced the commit. I think it's all good to go now, although the Sliverlight #if conditionals are quite cumbersome.

An alternative approach would be to introduce a ColoredConsoleOutLoggerFactoryAdapter and a ColoredConsoleOutLogger and add them only to the non-SL assemblies. If you'd rather go down that route then let me know and I can redo the feature in that manner.

[blairconrad]

If the level isn't found, color will become default(ConsoleColor), which is black. Based on the values in colors, I think we're assuming a dark (black?) background, so that's perhaps not ideal. Maybe better to detect the missing value and fall back to originalColor?

While I'm griping, no love for people with light-coloured backgrounds? 😉

[adamralph]

Does TryGetValue() specifically assign default(T) if the key is not found? I guess it might at least. I'll change it to be immune to that.

Light backgrounds - it crossed my mind too but for now I just went with replicating the default behaviour of the NLog ColoredConsoleTarget with regard to the chosen foreground colors as well as not altering the background color. I guess something clever to detect the lightness of the background and switch to a dark foreground scheme could be added later.

[adamralph]

[blairconrad]

Does TryGetValue() specifically assign default(T) if the key is not found?

That's how I read the docs.

And, yup. Look:

C:\PortableApps\Documents\Source>scriptcs
scriptcs (ctrl-c to exit)

> var dict = new Dictionary<string, System.ConsoleColor>();
> var originalColor = System.ConsoleColor.White;
> dict.TryGetValue("ERROR", out originalColor);
false
> originalColor
0
> (int)System.ConsoleColor.Black
0
> (int)System.ConsoleColor.White
15

[blairconrad]

I guess something clever to detect the lightness of the background and switch to a dark foreground scheme could be added later.

Yeah. I was just having a little fun with you on that one. Sorry.

[adamralph]

Has anyone had a chance to look at this PR? I'm happy to re-visit if required.

[sbohlen]

@adamralph I'll take a look at it this week and let you know -- thanks for the contribution and sorry for the delayed response!

[adamralph]

😢

[sbohlen]

Hang tight -- this weekend is "common.logging weekend" for me so I'll get this in shortly (promise). I've been traveling ridiculously-much for work the past ~30 days.

[adamralph]

😃

Sure, no probs. I know how it is...

[sbohlen]

Per your comment ...

An alternative approach would be to introduce a ColoredConsoleOutLoggerFactoryAdapter and a ColoredConsoleOutLogger and add them only to the non-SL assemblies.

...could you re-jigger your PR to use this approach? Now that I've restructured the relationships betw the PCL assemblies and the non-PCL assemblies (so that there's no longer any dependency betw. the two) your suggestion here re: the 'cleaner' way to approach this is actually much more appropriate.

Thanks again for the contribution!

[sbohlen]

Actually, scratch that -- I'll actually do this myself since its relatively straightforward to accomplish in short order....

[sbohlen]

Just FYI, since its the Common.Logging.Portable project that forms the basis for the Silverlight support and ConsoleOutLogger only exists in Common.Logging, I was able to remove all of the IFDEFs from the PR before merging it. Simplicity achieved!

[adamralph]

😂 thanks!

[sbohlen]

Sorry, just realized that I'm wrong -- there's been so much restructuring of the code here lately that I failed to realize that the ConsoleOutLogger does in fact also appear in the Silverlight project so I've added your IFDEFs back in -- so much for simplicty :-/

[LazyTarget]

Completed with implementation for setting useColor via NameValueCollection or web.config
Pull request: #182