Added reading configuration from App.config/web.config for .NET Core#180
Open
robsosno wants to merge 1 commit intonet-commons:masterfrom
Open
Added reading configuration from App.config/web.config for .NET Core#180robsosno wants to merge 1 commit intonet-commons:masterfrom
robsosno wants to merge 1 commit intonet-commons:masterfrom
Conversation
It would be better to do that only if System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription contains ".NET Core" Unfortunately this requires elevated permissions so I haven't done this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is necessary when classic .NET Framework is using .NET Core version of Common.Logging.
It would be best to check in runtime if classic .NET Framework application is running. However I haven't found a good method to do so and this change doesn't harm pure .NET Core applications.