Skip to content

Fix OOB in log_newpage_range #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knizhnik merged 1 commit into from
Jan 27, 2026
Merged

Fix OOB in log_newpage_range #877

knizhnik merged 1 commit into from
Jan 27, 2026

Conversation

@knizhnik
Copy link

@knizhnik knizhnik commented Jan 24, 2026

See https://databricks.slack.com/archives/C092W8NBXC0/p1768911662770739
and https://databricks.atlassian.net/browse/LKB-8536

Commit 3750bd5 (PG18 port to Neon) adds to log_newpages_range function code which force setting of BM_PERMANENT flag. This code

  1. contains bug (OOB)
  2. is redundant (bit is already set by Postgres)
  3. is useless - right now presence of this flag can not somehow affect performance

So undo this changes.

@knizhnik knizhnik merged commit a027103 into REL_18_STABLE_neon Jan 27, 2026
1 check passed
@knizhnik knizhnik deleted the log_newpage_range_oob_fix branch January 27, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmeent-databricks mmeent-databricks mmeent-databricks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knizhnik @mmeent-databricks