Skip to content

Fixed bug during review with duplicate videos #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
admiralorbiter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug during review with duplicate videos #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions story_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,24 +280,25 @@ def review(db_file: pathlib.Path, exe: str, label=None):
with sqlite3.connect(str(db_file)) as conn:
cur = conn.cursor()
if label is None:
media = list(cur.execute('SELECT m.id, media_path FROM media m JOIN locations l WHERE reviewed=0 AND media_path IS NOT NULL ORDER BY timestamp ASC'))
media = list(cur.execute('SELECT DISTINCT m.id, media_path FROM media m JOIN locations l WHERE reviewed=0 AND media_path IS NOT NULL ORDER BY timestamp ASC'))
else:
media = list(cur.execute('SELECT m.id, media_path FROM media m JOIN locations l WHERE l.label = ? AND reviewed=0 AND media_path IS NOT NULL ORDER BY timestamp ASC', (label,)))
media = list(cur.execute('SELECT DISTINCT m.id, media_path FROM media m JOIN locations l WHERE l.label = ? AND reviewed=0 AND media_path IS NOT NULL ORDER BY timestamp ASC', (label,)))
for idx, (idnum, v) in enumerate(media):
if exe is not None:
subprocess.call([exe, base_folder / v], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
else:
_open_default(base_folder / v)
if platform.system() in ('Linux', 'Darwin'):
# Flush all accidental double Return key presses
while select.select([sys.stdin.fileno()], [], [], 0.0)[0]:
os.read(sys.stdin.fileno(), 4096)
classification = input('Classify or leave blank:')
if not classification:
classification = None
cur.execute('UPDATE media SET reviewed=1, classification=? WHERE id=?', (classification, idnum))
conn.commit()
print(f'{len(media) - idx - 1} remaining')
print(f'{idx+1}/{len(media)}: {v}')
Copy link
Copy Markdown
Owner

@nemec nemec Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you commented out the code here and replaced it with a debug print statement.

# if exe is not None:
# subprocess.call([exe, base_folder / v], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
# else:
# _open_default(base_folder / v)
# if platform.system() in ('Linux', 'Darwin'):
# # Flush all accidental double Return key presses
# while select.select([sys.stdin.fileno()], [], [], 0.0)[0]:
# os.read(sys.stdin.fileno(), 4096)
# classification = input('Classify or leave blank:')
# if not classification:
# classification = None
# cur.execute('UPDATE media SET reviewed=1, classification=? WHERE id=?', (classification, idnum))
# conn.commit()
# print(f'{len(media) - idx - 1} remaining')


def export(db_file: pathlib.Path, export_dir: pathlib.Path, include_labels: bool):
Expand Down