Skip to content

Raiffeisen Mein Elba: Improve parsing of Payee and Bank Account#10

Open
akirk wants to merge 5 commits intonblock:masterfrom
akirk:patch-2
Open

Raiffeisen Mein Elba: Improve parsing of Payee and Bank Account#10
akirk wants to merge 5 commits intonblock:masterfrom
akirk:patch-2

Conversation

@akirk
Copy link

@akirk akirk commented Aug 7, 2020

This extends the parsing so that it now produces proper info for the payee, the bank account and the memo (just the Verwendungszweck).

@nblock
Copy link
Owner

nblock commented Aug 8, 2020

Thx for your contribution! Just two nitpicks:

  • Due to your change, the unittests fail
  • Could you provide a (anonymized and minimal) CSV export as it is currently generated by Raiffeisen?

@nblock
Copy link
Owner

nblock commented Dec 23, 2020

Could you please provide a minimal and anonymized CSV export from Raiffeisen that can be included to fix/update the tests?

@akirk
Copy link
Author

akirk commented Feb 18, 2021

@nblock sorry for the long wait, I've now added tests and fixed the existing ones.

I didn't know how to run unit tests, so here are some instructions of what I did:

I cloned https://github.com/kedder/ofxstatement and followed the test instructions there and then ln -sed the plugins directory from this repo and ran pytest from within the environment.

@JoelColledge
Copy link

I just used this. It works well 👍 I am for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants