FEATURE: add JSON operation (CREATE/SET/GET/DELETE)#962
Merged
namsic merged 1 commit intonaver:json-pocfrom Feb 27, 2026
Merged
FEATURE: add JSON operation (CREATE/SET/GET/DELETE)#962namsic merged 1 commit intonaver:json-pocfrom
namsic merged 1 commit intonaver:json-pocfrom
Conversation
namsic
reviewed
Feb 2, 2026
Collaborator
namsic
left a comment
namsic
left a comment
There was a problem hiding this comment.
전반적으로 코드 스타일 확인하고 정리해 주세요.
개발 중에 작성한 것으로 보이는 주석도 여럿 있는데 실제 반영할 때 포함시킬 의도로 작성한 주석이면 남겨 두고,
코드 작성 중에 참고하기 위해 남긴 메모 성격의 주석은 제거해 주세요.
Comment on lines
+1165
to
+1166
| } | ||
| void stats_prefix_record_jop_set(const char *key, const size_t nkey, const bool is_hit) { |
Collaborator
There was a problem hiding this comment.
사이에 빈 line 하나 들어가야 할 것 같습니다.
ing-eoking
reviewed
Feb 3, 2026
Collaborator
ing-eoking
left a comment
ing-eoking
left a comment
There was a problem hiding this comment.
JSON Item 자체는 Slab으로부터 공간을 할당하나 내부 element는 직접 malloc을 통해 할당받고 있는 것으로 보입니다.
이럴 경우 cost가 꽤 큰 것으로 보이는데, 혹시 이유가 있나요?
This comment was marked as resolved.
This comment was marked as resolved.
66Hello-world99
force-pushed
the
json
branch
5 times, most recently
from
d21bf62 to
5b60d39
Compare
ing-eoking
reviewed
Feb 12, 2026
| if (ret != ENGINE_SUCCESS) break; | ||
|
|
||
| if (!search_path_is_root_path(&jpn->sp)) { | ||
| if (search_path_find_ex(&jpn->sp, root, &jpn->n, &jpn->p) != ENGINE_SUCCESS) { |
Collaborator
There was a problem hiding this comment.
ENGINE_SUCCESS가 아닌 E_OK 로 변경하는 편이 좋을 것 같습니다.
engines/default/coll_json.c:241:71: error: comparison of different enumeration types ('path_error' and 'ENGINE_ERROR_CODE') [-Werror,-Wenum-compare]
241 | if (search_path_find_ex(&jpn->sp, root, &jpn->n, &jpn->p) != ENGINE_SUCCESS) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
| } | ||
| c->coll_attrp = &c->coll_attr_space; | ||
| process_jop_create(c, key, nkey, c->coll_attrp); | ||
| } |
Collaborator
There was a problem hiding this comment.
이곳에 아래 로직 추가
else {
print_invalid_command(c, tokens, ntokens);
out_string(c, "ERROR unknown command");
}
66Hello-world99
force-pushed
the
json
branch
from
5b60d39 to
697b9b6
Compare
66Hello-world99
force-pushed
the
json
branch
6 times, most recently
from
0ef4b90 to
5a22416
Compare
Collaborator
|
이전에 발표한 설계 내용이 PR에 반영된 상태인가요? |
66Hello-world99
force-pushed
the
json
branch
from
5a22416 to
32b3e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
https://www.notion.so/arcus-JSON-2edd913eacee80e2bf24dfb589122565?source=copy_link