CLEANUP: Reuse callback instance for repeated Op creation#1051
Merged
jhpark816 merged 1 commit intonaver:developfrom Feb 26, 2026
Merged
CLEANUP: Reuse callback instance for repeated Op creation#1051jhpark816 merged 1 commit intonaver:developfrom
jhpark816 merged 1 commit intonaver:developfrom
Conversation
Collaborator
|
@f1v3-dev CI 확인 바랍니다. |
f1v3-dev
force-pushed
the
fix/op-callback
branch
from
6cb93f8 to
6e131de
Compare
oliviarla
previously approved these changes
Feb 26, 2026
jhpark816
reviewed
Feb 26, 2026
| public void complete() { | ||
| rv.complete(); | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
위의 코드는 checkState(); 호출하기 전으로 옮기면 좋겠습니다.
PR 전체 코드에서 함께 수정 바랍니다.
f1v3-dev
force-pushed
the
fix/op-callback
branch
from
6e131de to
1a46e8e
Compare
jhpark816
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
Operaiton을 생성하는 연산에서 반복문 내에 동일한 로직의Callback을 생성하고 있었습니다.Callback을 단일 인스턴스로 생성하고 공유하는 형태로 변경했습니다.변경사항
flush,asyncCollectionInsertBulk2,btreeGetBulk,btreeGetBulkByteArrayBKeyflush,listSaslMechanisms,waitForQueues