feature: Add gateway parameter in peers #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natesales
requested changes
Dec 16, 2023
Owner
natesales
left a comment
natesales
left a comment
There was a problem hiding this comment.
Can we add a check to validate that the string value is either "direct" or "recursive"?
natesales
reviewed
Apr 14, 2024
| } | ||
|
|
||
| if peerData.Gateway != nil { | ||
| peerData.Gateway = util.Ptr(strings.ReplaceAll(*peerData.Gateway, "-", "_")) |
Owner
There was a problem hiding this comment.
Can we refactor to assign directly rather than with a util.Ptr call? That's really just a helper function for constants.
*peerData.Gateway = strings.ReplaceAll(*peerData.Gateway, "-", "_")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #197 , it should be possible to set the gateway mode in peers, in which the gateway is determined.
The strings 'direct' or 'recursive' can be assigned to the gateway parameter.
Details to the "gateway" functionality are also described in the bird documentation: https://bird.network.cz/?get_doc&v=16&f=bird-6.html