Fix #2638, Use unsigned format specifier for perf marker log#2682
Open
heathdutton wants to merge 1 commit intonasa:mainfrom
Open
Fix #2638, Use unsigned format specifier for perf marker log#2682heathdutton wants to merge 1 commit intonasa:mainfrom
heathdutton wants to merge 1 commit intonasa:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #2638
The
CFE_ES_WriteToSysLogcall inCFE_ES_PerfLogAdduses%dto formatMarker(which isuint32, cast tounsigned int) andCFE_MISSION_ES_PERF_MAX_IDS - 1. Changed both format specifiers to%uso the format string matches the actual argument types.Testing performed
Code review. Verified the existing unit test in
es_UT.ccovers the invalid marker path and does not assert on message text, so no test changes needed.Expected behavior changes
Marker values with bit 31 set will now print as the correct unsigned value instead of a misleading negative number. No other behavior change.
System(s) tested on
Code review only (macOS does not support cFS native build)
Contributor Info
Heath Dutton