Fix #2637, write perf log data in raw buffer order#2681
Open
heathdutton wants to merge 1 commit intonasa:mainfrom
Open
Fix #2637, write perf log data in raw buffer order#2681heathdutton wants to merge 1 commit intonasa:mainfrom
heathdutton wants to merge 1 commit intonasa:mainfrom
Conversation
The perf log dump was reordering entries by starting from DataStart, but the metadata written to the file still contained the original DataStart/DataEnd indices. This caused consumers to skip entries when parsing the file. Start the dump at index 0 so the file data matches the metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The perf log dump reorders data entries by starting the write loop from
MetaData.DataStart, but the metadata written to the file still contains the originalDataStart/DataEndindices. Consumers that use those indices to parse the file end up skipping entries.Testing performed
SIMULATION=native ENABLE_UNIT_TESTS=trueExpected behavior changes
System(s) tested on
Additional context
One-line fix: changed
State->DataPos = Perf->MetaData.DataStarttoState->DataPos = 0inCFE_ES_RunPerfLogDump. This stops the reordering so the raw buffer layout matches the metadata that was already being written as-is.Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Heath Dutton / Personal