Fix #2556, flight like platformed defined values#2557
Open
Fix #2556, flight like platformed defined values#2557
Conversation
Contributor
|
Might be a surprise to anyone using the defaults? Is there a way to match the BVTs w/o open source behavior changes? |
Contributor
Author
|
Yep - we could just put the updates in the example_platform_cfg.h (and change the name as part of the test setup). I'm a bit surprised that the functional tests failed, as I just changed CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC back to it's original value that I was thinking was more flight like. The only reason we changed it in the first place was to prevent test results from being squelched in the console output (cfe_test.log has always been correct). In any case, just using example_platform_cfg.h fixes both issues...I'll push an update. |
Collaborator
|
@dmknutsen Would you be able to go over this one at next week's CCB? |
dzbaker
added a commit
that referenced
this pull request
Dec 30, 2024
Fix #2556, flight like platformed defined values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Updates CFE_PLATFORM_EVS_LOG_MAX and CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC to align with 'flight like' values
Testing performed
CI pipeline
BVT testing
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA Goddard