Fix #1397, Rename overloaded EVS_PacketID_t to EVS_EventContext_t#2348
Open
thnkslprpt wants to merge 1 commit intonasa:mainfrom
Open
Fix #1397, Rename overloaded EVS_PacketID_t to EVS_EventContext_t#2348thnkslprpt wants to merge 1 commit intonasa:mainfrom
EVS_PacketID_t to EVS_EventContext_t#2348thnkslprpt wants to merge 1 commit intonasa:mainfrom
Conversation
658c84e to
4cc2a65
Compare
4cc2a65 to
c6553fc
Compare
jphickey
reviewed
May 23, 2024
Contributor
jphickey
left a comment
There was a problem hiding this comment.
In general I prefer the name "context" but this changes a public API. Some existing apps are referring to the PacketID name so it requires more discussion as to whether we really want to change it. For example the "HS" app is using PacketID, so this breaks HS. At a minimum this would need to go through the deprecation process (but I'm not sure if a simple name change warrants that, if nothing was actually broken)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_EVS_PacketID#1397CFE_EVS_PacketID_ttype toCFE_EVS_EventContext_tTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt